Better support for custom directives #825
Closed
rwysocki-equinix wants to merge 2 commits intoCode-Hex:mainfrom
Closed
Better support for custom directives #825rwysocki-equinix wants to merge 2 commits intoCode-Hex:mainfrom
rwysocki-equinix wants to merge 2 commits intoCode-Hex:mainfrom
Conversation
* Add support for directives without arguments like `@required()` * Add support for custom directive mapping Closes Code-Hex#422, Code-Hex#781
Code-Hex
reviewed
Nov 7, 2024
Comment on lines
-47
to
-74
| describe('formatDirectiveObjectArguments', () => { | ||
| const cases: { | ||
| name: string | ||
| arg: DirectiveObjectArguments | ||
| want: FormattedDirectiveObjectArguments | ||
| }[] = [ | ||
| { | ||
| name: 'normal', | ||
| arg: { | ||
| uri: 'url', | ||
| email: 'email', | ||
| }, | ||
| want: { | ||
| uri: ['url', '$2'], | ||
| email: ['email', '$2'], | ||
| }, | ||
| }, | ||
| { | ||
| name: 'contains array', | ||
| arg: { | ||
| startWith: ['matches', '/^$2/'], | ||
| email: 'email', | ||
| }, | ||
| want: { | ||
| startWith: ['matches', '/^$2/'], | ||
| email: ['email', '$2'], | ||
| }, | ||
| }, |
Owner
There was a problem hiding this comment.
I think it is important to maintain backward compatibility. Where have these test cases gone? I would like to see them restored if possible.
Code-Hex
reviewed
Nov 7, 2024
Owner
Code-Hex
left a comment
Code-Hex
left a comment
There was a problem hiding this comment.
I think the direction is good and it would be helpful if you could respond to the comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@required()Closes #422 , #781